search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
GNU General Public License v3.0
29 stars 71 forks source link

FIX: use correct group for recursive ldap groups refs #82503 #1

Closed Starkmann closed 6 years ago

Starkmann commented 6 years ago

Fixes the following issue. https://forge.typo3.org/issues/82503

utrotzek commented 6 years ago

I'm happy to see that this issue has been fixed. But this fix seems to be not part of the current release 3.3.0.

I can find that commit in the current master (before the 3.3.0 version raise) https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/commits/master

But not in the tagged 3.3.0 release https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/commits/3.3.0

Am I missing something or is it just planned for the next release?

xperseguers commented 6 years ago

I don't understand what you mean by "I can find the commit in the current master master before the 3.3.0 version raise).

When I follow this link, that is the commits on master, I see that this merge happened after commit 43242b06e98437ba30a44571483251406a2358fe which is the raise to version 3.4-dev, so I don't know how you expect it to be part of release 3.3.0

utrotzek commented 6 years ago

Hmm. Maybe i oversee something. On a fresh clone When I use: git log master --oneline

75628b4 [TASK] Raise version to 3.3.0
dc8ed7a Update Groups.rst
8925710 Merge branch 'master' of github.com:undkonsorten/t3ext-ig_ldap_sso_auth
1e4a1e5 [TASK][DOC] Update links
0a1e269 FIX: use correct group for recursive ldap groups refs #82503

The commit 0a1e269 FIX: use correct group for recursive ldap groups refs #82503is before the version raise.

But when I use git log 3.3.0 --oneline

75628b4 [TASK] Raise version to 3.3.0
1e4a1e5 [TASK][DOC] Update links
ec2b623 [TASK][DOC] Describe workaround for untrusted LDAP server certificate
39dcbfb [BUGFIX] Prevent call to undefined method when authenticating in BE
d66c087 [BUGFIX] Check availability of ldap_control_paged_result()
241e76d [!!!][TASK] Remove NOT NULL constraints for blob columns
04ac15c [TASK] Add index keys on important columns
28477e9 [TASK] Raise version to 3.3.0-dev

The commit 0a1e269 FIX: use correct group for recursive ldap groups refs #82503 is not present.

It's no problem at all but that was confusing me a little bit. :sweat_smile: