xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 68 forks source link

[TASK] #7 #8 - TYPO3 v9 compatibility #10

Closed waldhacker1 closed 4 years ago

waldhacker1 commented 6 years ago

TYPO3 v9 compatibility

masi commented 5 years ago

The patch is most welcome. Too bad it introduces many changes unrelated to TYPO3 9 compatibility.

Reorderding lines and changed whitespaces makes it harder to review the patch. Also the patch removes support for TYPO3 before 7.5. Probably ok as LTS is 7.6, but again this makes it a bit hard to understand what the patch really does.

We'll see if Xavier finds the time to merge this one.

sebeka commented 5 years ago

Hi,

I tested the patch with Typo3 9.5.1 . I know, 9.5 > 9.2, which is given as max-version in ext_emconf, but maybe it is not to complicated to make it working for 9.5

Syncing groups is working fine, but during import to database I have problems:

An exception occurred while executing 'INSERT INTO `be_groups` (`pid`, `tstamp`, `crdate`, `cruser_id`, `deleted`, `hidden`, `description`, `title`, `non_exclude_fields`, `explicit_allowdeny`, `allowed_languages`, `custom_options`, `db_mountpoints`, `pagetypes_select`, `tables_select`, `tables_modify`, `groupmods`, `file_mountpoints`, `file_permissions`, `locktodomain`, `tsconfig`, `subgroup`, `workspace_perms`, `category_perms`, `tx_igldapssoauth_dn`)
 VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params [0, 1544448970, 1544448970, "0", "0", "0", null, "", null, null, "", null, null, "", null, null, null, null, null, "", null, null, "1", null, null]:
Column 'tx_igldapssoauth_dn' cannot be null 

I added already some mappings but this does not help:

title = <cn>
dn = <dn>
tx_igldapssoauth_dn = <dn>

The correct DN is shown with the synced groups in the backend module in "Import LDAP groups (Backend) "

An other point is, that the column "__extraData" is not available in table be_groups, I commented the lines in the code just for a quick try.

Thanks, Sebastian

xperseguers commented 4 years ago

V9 is supported in the mean time.