search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 64 forks source link

[BUG] Method signature not compatible with abstract class #101

Closed mschwemer closed 4 years ago

mschwemer commented 4 years ago

In the import task there is a method "getLanguageService", which is also defined in the abstract class EXT:scheduler/Classes/Task/AbstractTask.php. This leads to the following exception, when opening the module "Scheduler"

Fatal error: Declaration of Causal\IgLdapSsoAuth\Task\ImportUsers::getLanguageService() must be compatible with TYPO3\CMS\Scheduler\Task\AbstractTask::getLanguageService(): ?TYPO3\CMS\Core\Localization\LanguageService in /app/private/typo3conf/ext/ig_ldap_sso_auth/Classes/Task/ImportUsers.php on line 359

Solution is, to rename the function, so it will also work on older TYPO3 versions.

I'll send a PR in a couple of minutes.

Version Info TYPO3 version: 10.4.4 php version: 7.4 EXT version: 3.5.1