xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 62 forks source link

check method arguments instead of suppressing warnings/errors in LdapUtility #115

Closed hannesbochmann closed 3 years ago

hannesbochmann commented 3 years ago

The arguments passed to ldap_get_dn() in LdapUtility::getDn() and ldap_get_attributes() in LdapUtility::getAttributes() are not checked if they are a resource. They can be a boolean value which leads to a warning. To work around this the warnings/errors of those functions are suppressed with "@". This is bad design. It would be better to check those arguments and act accordingly. I will provide a pull request to optimize this.