search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 68 forks source link

Throw exception if group is not added #17

Closed pixelbrackets closed 4 years ago

pixelbrackets commented 6 years ago

Feature request: Throw exception if adding a group is not possible in backend module.

Situation

The backend module lists groups and it is possible to import them into the CMS using a button.

Expected behavoir: Add new groups to the CMS.

Actual behaviour (on my instance): Start the import process upon button click, but then fail silently (no error message apears in the AJAX request) .

Reason

In my case the installation uses PostgreSQL, which failed when I tried to add a new group, because the given dataset did not match with the expected SQL query statement.

The insert statement then fails, but the module doesn't show an error.

Line 451 should throw an exception if adding the group was not possible for whatever reason: https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/blob/master/Classes/Controller/ModuleController.php#L451

(The same behavour applies to »Authentication«.)

xperseguers commented 4 years ago

Is it related to #30?

xperseguers commented 4 years ago

Would you mind testing again? and if this fails, before throwing an exception which won't help much anyway, I'd like to know what exactly is failing in the SQL query statement.