xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 68 forks source link

User synchronisation: Attributes condition is always true #19

Closed pixelbrackets closed 4 years ago

pixelbrackets commented 6 years ago

The method to retrieve an LDAP user has a condition which is always true:

https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/blob/master/Classes/Library/Authentication.php#L256

This should be avoided. Either set the attributes to an empty array by default and remove the condition, or do an actual check.