search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 70 forks source link

Make extension compatible with TYPO3 v12 and PHP 8.2 #190

Open hannesbochmann opened 10 months ago

hannesbochmann commented 10 months ago

As the PR #174 does not contain PHP 8.2 support which is essential for TYPO3 12, I added it. Furthermore I fixed some minor issues in the BE module and incorporated https://github.com/datamintsGmbH/t3ext-ig_ldap_sso_auth/pull/1 .

To be clear. The main contribution still comes from datamints. So thanks for their effort.

mschwemer commented 10 months ago

Thanks for your work.

In my fork, I added other bugfix to make the creation of fe user records work as expected. Currently the replaced TYPO3_MODE is always BE. Maybe you want to integrate it here too.

Besides that: I do not think, that @xperseguers will merge the PR regarding his support strategy. At the same time, I don't like it to run an extension on a fork.

What do you think about joining forces to make it compatible for v11 and v12? I probably would get some time from my PM and / or customers to get that "fixed".

hannesbochmann commented 10 months ago

I could invest some more time but I'm afraid not that much. And yeah, I will integrate your new fixes aswell. Just give me a sec.

sk-foresite commented 10 months ago

Hey, thanks for providing a TYPO3 v12 Version of this extension!

I found an issue with the initialization of the backend configuration. It always seems to use the frontend configuration because the check against the mode is wrong.

I commited a fix in my branch: https://github.com/sk-foresite/t3ext-ig_ldap_sso_auth/commit/f3cacb020f73e6ed213f479180186277a749a8bb

hannesbochmann commented 10 months ago

@sk-foresite It's only this small change or anything else I should cherry-pick/merge?

sk-foresite commented 10 months ago

@sk-foresite It's only this small change or anything else I should cherry-ick/merge?

It's only this change.

hannesbochmann commented 10 months ago

@sk-foresite I will incorporate your changes into my fork.

hannesbochmann commented 10 months ago

I cherry picked your commit. Thanks for the contribution.