search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
GNU General Public License v3.0
30 stars 74 forks source link

Undeclared arguments passed to ViewHelper TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper: onchange. #234

Closed eibiflo closed 3 weeks ago

eibiflo commented 3 weeks ago

Hello, I just installed the extension on a Typo3 11 instance, and I'm getting the following error in the backend module:

Undeclared arguments passed to ViewHelper TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper: onchange. Valid arguments are: additionalAttributes, data, aria, name, value, property, class, dir, id, lang, style, title, accesskey, tabindex, onclick, size, disabled, options, optionsAfterContent, optionValueField, optionLabelField, sortByOptionLabel, selectAllByDefault, errorClass, prependOptionLabel, prependOptionValue, multiple, required

The onchange argument is registered in Causal\IgLdapSsoAuth\ViewHelpers\Form\SelectViewHelper, but it’s not being loaded automatically.

Did I do something wrong here, or is this a bug? I couldn’t find anything specific in the documentation at first glance, so I thought I'd ask.

TO fix: I adjusted the template and inherited from your ViewHelper instead of using f: "fluid"

With <ig:form.select, it would work without any issues. Should I create a PR with the fix?

xperseguers commented 3 weeks ago

Is it really still a problem (you are using the latest release) or did you check with master branch?

It’s supposed to be fixed since #226

eibiflo commented 3 weeks ago

Thanks for the info! I downloaded the latest version from the TER, and the error was still present, but it's working again in the master branch, thanks!

However, I’m now getting a different error: (1/1) Error Typed property Causal\IgLdapSsoAuth\Utility\LdapUtility::$status must not be accessed before initialization in /var/www/html/typo3conf/ext/ig_ldap_sso_auth/Classes/Utility/LdapUtility.php line 520>

Is this also a known issue?

Typo3 11.5 PHP 8.1

xperseguers commented 3 weeks ago

Thanks for the info! I downloaded the latest version from the TER, and the error was still present, but it's working again in the master branch, thanks!

Great.

However, I’m now getting a different error: (1/1) Error Typed property Causal\IgLdapSsoAuth\Utility\LdapUtility::$status must not be accessed before initialization in /var/www/html/typo3conf/ext/ig_ldap_sso_auth/Classes/Utility/LdapUtility.php line 520>

Is this also a known issue?

No, as I don't remember having seen an existing ticket with that problem. I can't have a look right now, should be easy to fix if you want to try and create a PR.

Since original problem is thus solved in master branch, I suggest you then close that ticket.

eibiflo commented 3 weeks ago

Thanks for the fast Feedback!

PR is opened