Closed geraldaistleitner closed 5 years ago
I don’t really get the point of manually setting a LDAP timeout. I would be fine to set a sensible timeout to prevent a very long default timeout but I don’t see why one would like to set say 5 seconds and another 30. a LDAP call should not last more than a few ms anyway.
On 12 Nov 2018, at 10:51, geraldaistleitner notifications@github.com wrote:
Can be used if there are more options available for login to lower the time till response. Additionally I implemented a fallback for logging as diagnostic was empty in slot if LDAP server was not reachable.
You can view, comment on, or merge this pull request online at:
https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/pull/42
Commit Summary
[FEATURE] Add configuration option to set ldap timeout to custom value File Changes
M Classes/Domain/Model/Configuration.php (21) M Classes/Domain/Repository/ConfigurationRepository.php (1) M Classes/Library/Authentication.php (3) M Classes/Library/Configuration.php (1) M Classes/Library/Ldap.php (7) M Classes/Utility/LdapUtility.php (7) M Configuration/TCA/tx_igldapssoauth_config.php (14) M Resources/Private/Language/locallang_db.xlf (3) M ext_tables.sql (1) Patch Links:
https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/pull/42.patch https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/pull/42.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Can be used if there are more options available for login to lower the time till response. Additionally I implemented a fallback for logging as diagnostic was empty in slot if LDAP server was not reachable.