xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 68 forks source link

pagination failure in some instances #43

Closed someplace53 closed 4 years ago

someplace53 commented 5 years ago

I have the problem that at least some of my defined typo3-ldap groups which should contain more than 100 entries, are containing only 100 entries.

As far as I can tell this is a pagination issue caused by an flawed condition in

namespace Causal\IgLdapSsoAuth\Utility;
class LdapUtility {
[...]
public function hasMoreEntries()
{
    return !empty($this->paginationCookie);
}
[...]

a valid value for the paginationCookie seems to be "0", which indicates that there are more values.

If you change the return line to:

return $this->paginationCookie !== null && $this->paginationCookie != '';

it seems to work. The line was taken from the php documentation.

The test where made with a Linux Apache Webserver with php 7.2 against an OpenLDAP server.

The problem seems not to be for all groups which is a bit irritating.

I hope this helps and I get an official fix for this :-)