xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 68 forks source link

Change limit for amount of users to a configurable value (function getAvailableUsers) #50

Open tobiasschaeferptb opened 5 years ago

tobiasschaeferptb commented 5 years ago

Hi Xavier,

could you please change the limit for the amount of users in function getAvailableUsers (Classes/Controller/ModuleController.php line 674) to a configurable value instead of the hardcoded 2000. I suggest to make it configurable throught the extension manager (e.g. in the basic tab) or in the ldap configuration (e.g. in the ldap tab).

Cheers, Tobias

xperseguers commented 4 years ago

As the comment states:

// Current Extbase implementation does not properly handle
// very large data sets due to memory consumption and waiting
// time until the list starts to be "displayed". Instead of
// waiting forever or drive code to a memory exhaustion, better
// stop sooner than later

to me instead of showing more than 2000 records (which is already huge), the module should possibly be enhanced to allow filtering and thus be allowed to "search" for users to be imported.

githubUser123444 commented 2 years ago

Hi Xavier,

as this issue is not closed yet, i am asking you to rethink your decision not to make the default limit of importable ldap users (2000) editable from the backend.

Line 709 in Classes/Controller/ModuleController.php

if (count($users) >= 2000) { break; }

Cheers, Felix

fishbone1 commented 1 year ago

Also, is there an option to import the user on login, if it doesn't exist? We have about 5000 users. Many will never login. I thought this is what TYPO3FEUserExist option is for, but unchecking it doesn't work.

xperseguers commented 1 year ago

@fishbone1 That's the default behaviour, if it "doesn't" work, you're probably missing something related to user groups. Please check that the user gets created in table fe_users, if it does but is marked as "deleted" then you mixed-up group configuration, like enforcing user groups but without mapping them.

fishbone1 commented 1 year ago

@xperseguers Yes, it works. Great! The missing users had wrong OUs.