Use hosts from site configurations for domain restriction

[jonakieling]

Hi there,

we currently have a project where we try to remove the need for sys_domain records. One last thing was the host validation of this extension using only sys_domain records.

• This PR adds a field to the configuration model for storing site configurations.

• The hosts of those site configurations are then included in the list of domains checked by the extensions AuthenticationService.

• The TYPO3 Core API SiteFinder is used to get the site configurations and resolve the currently used variant and its host.

I'm very much open for suggestions regarding the changes. :)

kind regards, jona

[stat1x]

Hi, Would it not be better to have the LDAP configuration in the "Sites" module directly?

[jonakieling]

Hey,

the solution provided by the PR is mainly motivated by its simplicity since it uses the already existing code for the domain restrictions. But I like the idea of having the LDAP config that is somewhat attached to a domain in the site config. As of right now I'm not too familiar with this extensions code base so I find it difficult to guess the time needed to implement the site config variant of this PR. It would also be a separate PR.

Here are some pros and cons that come to mind:

pros

• all the LDAP config and mappings are under version control when put in a sites config yaml
• domain restrictions are obsolete since the LDAP config is explicit for each site
• site variants and environment variables can be used for different connections and credentials

cons

• when using multiple sites with the same LDAP config, each site needs to have the config in its entirety
• probably more time consuming than just adding the site configs domains

The last one is a bit of a blocker right now. I'll keep an eye on this and maybe find some time in the future for some coding. Right now we are using the current release since we have the same issue with the current ext:solr which only has a PR for adding the solr config to the site config for a later release.

regards, jona

[stat1x]

Thanks for the analysis. I agree with your pros/cons. Maybe we need to wait for EXT:solr to find a solution for this and then see how they managed this. Best, Jay.

[jonakieling]

Hi @xperseguers ,

do you have plans for supporting the site based configuration? Can this PR or the above mentioned proposals be of any help? Are there other ways to support?

regards, jona

[jonakieling]

Hi,

the changes are incorporated with two commits. Do you want them to be squashed to one commit only?

[xperseguers]

I have the feeling that we should merge domains and site configuration in the extension. domains are deprecated since TYPO3 v9. Some business logic uses domains internally for checking for matching of configuration record or not, we may possibly merge them (you may have a look at branch feature/typo3-v10).

[jonakieling]

I have cleaned up the commits and will look into the typo3-v10 branch with a clear mind and report back.