search

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.
https://extensions.typo3.org/extension/ig_ldap_sso_auth
27 stars 64 forks source link

Add support for site configuration domains #67

Closed jonakieling closed 4 years ago

jonakieling commented 5 years ago

Hi everyone,

since TYPO3 9 we can set up our domains with the site configurations. I have prepared a PR #60 that adds domains from site configurations alongside the domains from domain records for the authentication restriction. The domains are added to the central list of domains.

Any tests and feedback are appreciated.

All the best jona

xperseguers commented 4 years ago

Hello. You have closed your PR, don't know if this is still valid? If so, and after having a quick look at the PR, feel free to open it again while fixing obvious typos such as additional blank spaces in use, sticking to conventions used for commit message etc.

jonakieling commented 4 years ago

Hi,

we have this patch in production for a while now and all works fine. I jut re-opened the PR.

I'll fix the wrong indentation. You used plural for typos, could you comment on the commits what could be improved upon?

I'm not sure what conventions are not met. Altough I tried to keep it simple and to the point my general go-to for commit messages are those from the TYPO3 Development Team at https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html

Regards, jona

xperseguers commented 4 years ago

This change will actually be needed for full non-legacy compatibility already with TYPO3 v9. In TYPO3 v10, table sys_domain does not exist anymore.

This is not urgent, but we will need to mark the usage of sys_domain in TYPO3 v9 as deprecated once this support for site configuration has landed to master.