Switch check to isset() for getting empty strings as default value

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.

https://extensions.typo3.org/extension/ig_ldap_sso_auth

27 stars 64 forks source link

Switch check to isset() for getting empty strings as default value #83

Closed spoonerWeb closed 4 years ago

spoonerWeb commented 4 years ago

Closes: #82

frommo commented 4 years ago

Hi,

it is correct to use isset() instead of empty() in this case, but the condition should be reversed. The ! before isset() should be deleted so the default is applied if one is set.

Currently the condition is only true if the default is not set, it should be the other way around. Please remove the ! at the start of the if clause.

Kind regards, Christian