[Bugfix] Remove getLanguageService from Import Task for TYPO3 10 compatibility

xperseguers / t3ext-ig_ldap_sso_auth

TYPO3 Extension ig_ldap_sso_auth. This extension provides LDAP and SSO support for TYPO3.

https://extensions.typo3.org/extension/ig_ldap_sso_auth

27 stars 64 forks source link

[Bugfix] Remove getLanguageService from Import Task for TYPO3 10 compatibility #98

Closed stauer closed 4 years ago

stauer commented 4 years ago

Function declaration is not valid any more. Using default function from AbstractTask instead.

stauer commented 4 years ago

Good point ;-) I think there are 2 options:

Releasing a version with minor TYPO3 version requirement of 10.4 LTS, or
inserting a condition inside ext_localconf.php, checking TYPO3 Version and therefore registering different Task-Classes

What do you think?

xperseguers commented 4 years ago

What I think is that you did not create a bug report, so I can only guess what the problem is you try to fix. What's exactly the problem in v10, why does it crash? I can't understand by reading, I need to dig into the code...

Well, by digging, I still don't see what is broken.

stauer commented 4 years ago

The function is not compatible any more with TYPO3 10 core. It's not overwritten correctly. Trying to add scheduler task leads to an PHP fatal error.

xperseguers commented 4 years ago

should be fixed by 36acf5cc0b2c8a08ebbde38da79b18707fad28cb with compatibility with former versions as well.

xperseguers commented 4 years ago

Cannot reproduce anymore.