Fix method signature of overwritten method SchedulerModuleController::addMessage

xperseguers / t3ext-image_autoresize

TYPO3 Extension image_autoresize. Simplify the way your editors may upload their images.

https://extensions.typo3.org/extension/image_autoresize

GNU General Public License v3.0

16 stars 22 forks source link

Fix method signature of overwritten method SchedulerModuleController::addMessage #93

Closed cepheiVV closed 9 months ago

cepheiVV commented 9 months ago

As described in Issue #80, the backend module in TYPO3 v12.4 crashes when trying to add a new task. This PR fixes the method signature of addMessage to be compatible with its parent method and thus fixing the fatal error in the backend.

christophlehmann commented 9 months ago

Works 👍

xperseguers commented 9 months ago

I wonder how this can work:

$moduleTemplate is not passed to parent method
method signature doesn't match in TYPO3 v10 at least

xperseguers commented 9 months ago

isn't it somehow another fix for #88 ?

cepheiVV commented 9 months ago

@xperseguers Yes, it is. But #88 looks like it will take a while since this change seeks to implement a lasting solution. However, in this pull #93 we have a quickfix, that allows to use the Backend again while you guys figuring out how to fix #88 properly. The production backend is currently broken since we cannot add scheduler tasks, and this change here will at least make the backend accessible again.

kaystrobach commented 9 months ago

can only second that, a short termin fix is appreciated.

cepheiVV commented 9 months ago

We're probably uninstalling ext.image_autoresize for now. Can't use the Scheduler backend anymore. Will reinstall as soon as this gets merged or we have a solution in https://github.com/xperseguers/t3ext-image_autoresize/pull/88

xperseguers commented 9 months ago

Thanks for the PR, but the direction I prefer to go is this one: https://github.com/xperseguers/t3ext-image_autoresize/tree/bugfix/scheduler-80