xperseguers / t3ext-routing

TYPO3 Extension routing
19 stars 6 forks source link

Ensure code follows PSR-2 coding guidelines #14

Closed schams-net closed 7 years ago

schams-net commented 7 years ago

As of version 0.5.0-dev, the code does not comply with PSR-2 coding guidelines. Most of the issues should be easy to fix, but I struggle to come up with an idea regarding the additional PHP code at the end of file RoutingController.php.

FILE: t3ext-routing/Classes/ViewHelpers/UriViewHelper.php
------------------------------------------------------------------------------------------
  41 | ERROR   | The closing brace for the class must go on the next line after the body
------------------------------------------------------------------------------------------

FILE: t3ext-routing/Classes/Controller/RoutingController.php
------------------------------------------------------------------------------------------
   1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.)
     |         | and cause no other side effects, or it should execute logic with side
     |         | effects, but should not do both. The first symbol is defined on line 28
     |         | and the first side effect is on line 335.
 161 | WARNING | Line exceeds 120 characters; contains 135 characters
 179 | WARNING | Line exceeds 120 characters; contains 122 characters
 181 | WARNING | Line exceeds 120 characters; contains 122 characters
 191 | WARNING | Line exceeds 120 characters; contains 154 characters
 201 | WARNING | Line exceeds 120 characters; contains 148 characters
 204 | WARNING | Line exceeds 120 characters; contains 137 characters
 332 | ERROR   | The closing brace for the class must go on the next line after the body
------------------------------------------------------------------------------------------

FILE: t3ext-routing/ext_localconf.php
------------------------------------------------------------------------------------------
   6 | WARNING | Line exceeds 120 characters; contains 129 characters
------------------------------------------------------------------------------------------

The report above does not include file Classes/Library/Spyc/Spyc.php due to the fact that this is a 3rd party library.