xpgo / obsidian-folder-note-plugin

Plugin to add description note to a folder for Obsidian.
397 stars 29 forks source link

Unescaped quotes in brief #4

Closed ngirard closed 3 years ago

ngirard commented 3 years ago

Folder note plugin uses the section titles of notes as brief when generating its JSON data.

When a section of a note contains a quote, the corresponding brief attribute contains an unescaped quote, leading to incorrect JSON contents that cannot be rendered.

xpgo commented 3 years ago

I didn't consider that at the begining. I will fix that in the next release, thanks.

ngirard commented 3 years ago

For the record: the problem also arises using v0.6.1 and when using the first paragraphs as briefs.

xpgo commented 3 years ago

The problem should have been fixed in v0.6.2, thanks. By the way, I have limited the max brief length to 64, if you want a longer brief, please use the briefMax key for ccard type of folder_brief_live. And, to escape the quotes, we should use double quotes, '' instead of \', because it is YAML format.

ngirard commented 3 years ago

The problem should have been fixed in v0.6.2

It has, thanks !

And, to escape the quotes, we should use double quotes, '' instead of \', because it is YAML format.

I was about to close this report, but you might want to add this information to the documentation first ?

xpgo commented 3 years ago

solved.

ngirard commented 3 years ago

@xpgo, you might want to add to the documentation

Cheers

xpgo commented 3 years ago

Corresponding explaination have already been added to the document: https://github.com/xpgo/obsidian-folder-note-plugin/blob/main/doc/ccard-syntax.md#item-types

ngirard commented 3 years ago

Great, thanks !