search

xpilot-project / xpilot

Open-source, cross-platform X-Plane pilot client for VATSIM.
https://xpilot-project.org
GNU General Public License v3.0
117 stars 35 forks source link

cannot close Settings popup (Linux xpilot AppImage v2.0.0-beta.49) #173

Closed sfrsfrsfr closed 8 months ago

sfrsfrsfr commented 11 months ago

i'm on Linux (Ubuntu 22.04) using the i3wm window manager. after clicking on 'Settings' i'm not able to close the popup, e.g. hitting Escape doesn't work and the main GUI window is loccked too. maybe i'm missing the obvious here?

xpilot

jonaseberle commented 11 months ago

Is that the AppImage? It misses the window decorations where you normally close the window. What window manager is that? I can only say that they are there on KDE.

sfrsfrsfr commented 11 months ago

as stated i'm using the i3 window manager and the xPilot AppImage. can i suggest to add buttons like Ok, Cancel to the Settings Popup and ideally a keybinding to ESC to 'Cancel & Close'? this is how many other GUIs are designed (e.g. Kate).

kate_popup

meanwhile i found an i3 option (border normal) that forces i3 to add a border to the Settings popup, this allows me to kill/close the popup. note that Kate (and basically all other applications) behave 'normal' out of the box under i3.

apart from that xPilot is working fine (with my limited testing), thx for your efforts!

jonaseberle commented 11 months ago

Sorry, I haven't parsed that you already stated i3.

The window currently tells Qt it is a Qt::Dialog: https://github.com/xpilot-project/xpilot/blob/master/client/Resources/Views/SettingsWindow.qml#L21

I wonder why ESC is not working in that dialog (for me neither), because that usually is implicitly enabled for a Qt dialog.

I don't know what would be correct and so that i3 shows a title bar. Maybe Qt::Window | Qt::WindowCloseButtonHint? https://doc.qt.io/qt-6/qt.html#WindowType-enum

Anyways, a "Close" button can't hurt either...

justinshannon commented 8 months ago

I have redesigned the Settings window, which should address this issue. The new version will be released sometime after CTP.

Settings

justinshannon commented 8 months ago

This is now available in beta 50.