search

xpipe-io / xpipe

Your entire server infrastructure at your fingertips
https://xpipe.io
Apache License 2.0
3.06k stars 82 forks source link

Title Bar color #281

Closed julianbrennum closed 3 months ago

julianbrennum commented 3 months ago

When running the software in darkmode on windows the title bar is still white. It does not follow the software's darkmode or windows theme. Would be nice if it would follow the windows theme or if it changed to black when the app is in dark mode.

image

crschnick commented 3 months ago

Yeah that is a current limitation of JavaFX. I'm not sure whether I can implement that myself through a native call or whether I have to wait for JavaFX to officially support it.

julianbrennum commented 3 months ago

Yeah that is a current limitation of JavaFX. I'm not sure whether I can implement that myself through a native call or whether I have to wait for JavaFX to officially support it.

I see, what about hiding the title bar and create a custom title bar within your JavaFX, effectively hiding the default system title bar and creating your own inside the app? By using undecorated style you can make the title bar follow the app's design language.

crschnick commented 3 months ago

I could do that but the custom window decoration would lose all functionality such as window snapping etc,, so it wouldn't be fun to use. I think having the title bar in white is a smaller issue than that

crschnick commented 3 months ago

Alright found a solution to this. If you are on Windows 11, you can try out the test build at https://github.com/xpipe-io/xpipe-ptb. I am primarily on Windows 10.

julianbrennum commented 3 months ago

Yes, it works perfectly! Running on W11. Great work, and thanks for the fast respond!

julianbrennum commented 3 months ago

Case closed, problem solved!