xpipe-io / xpipe

Your entire server infrastructure at your fingertips
https://xpipe.io
Apache License 2.0
3.42k stars 88 forks source link

File Manager does not save changes to temp files #300

Closed blunweon closed 4 months ago

blunweon commented 4 months ago

First off, would like to say that I love this app and it has made me switch over to religiously only use this.

However, after recent updates, I noticed that when I opened temporary files to edit (e.g settings.yml) and after saving, the changes are not reflected in the filesystem. image image image

As you can see, after editing the settings.yml, it did not reflect the changes in the filesystem and was still labeled as last updated "17:02", which was when I used WinSCP to manually go in and edit it.

Please let me know if I am doing something wrong, which caused this issue.

crschnick commented 4 months ago

So I haven't encountered this issue and am not able to reproduce this. Does this happen everywhere, all the time, or are there specific conditions? I assume this is Windows 11 with vscode as the editor?

blunweon commented 4 months ago

This has been happening to me since 10.0.3 I think, since I haven't really been trying to edit files through the file manager. Sometimes it works, sometimes it doesn't, but more often than not, it doesn't want to save.

This is Windows 11 with Sublime Text as the editor.

This is the logs when I try to edit and save a file.

xpipe.log

crschnick commented 4 months ago

I see that xpipe is using powershell as the local shell. It usually does that when cmd doesn't work as expected, maybe you got an error message about that on first launch.

You can see what happens if you go to Settings -> Local shell and disable the fallback.

I will test this with powershell

blunweon commented 4 months ago

I disabled the fallback and killed the task through task manager. It still does not seem to want to save, this are the logs after a short test:

xpipe.log

crschnick commented 4 months ago

Ok so what you can do is go to Settings -> Troubleshoot -> Launch in debug mode. That should print all file editing details.

You can send me the logs per email or discord or alternatively only paste the relevant part here.

blunweon commented 4 months ago

Okay so from what I can see, it does not think that there are changes in the file (might be due to it being small edits?) whenever I hit save on the text editor.

I encounter this problem as well when copying-and-pasting chunks of texts from start of file to end of file, where it thinks that there are no changes.

image

crschnick commented 4 months ago

I see the issue, it's a bug on my end

blunweon commented 4 months ago

Thank you for the fast response.

As from my limited understanding, the script checks for a change in file size, hence resulting in an update in file.

I'm wondering if a rearranging of texts in a .yaml file would still get updated through the File Manager as theoretically the size does not change as new texts are not being added?

Nonetheless, thank you for putting out such an amazing awesome product!

crschnick commented 4 months ago

It should check for time as well, but that is currently broken.

crschnick commented 4 months ago

This should now be fixed in 10.1.1

blunweon commented 4 months ago

This should now be fixed in 10.1.1

Thank you for the update!