xpipe-io / xpipe

Your entire server infrastructure at your fingertips
https://xpipe.io
Apache License 2.0
2.85k stars 77 forks source link

[Feature Request] Proxmox Tweaks #313

Open valdearg opened 1 month ago

valdearg commented 1 month ago

Hello!

First, absolutely love xpipe, the steady improvements to this has made it great to use and exactly what I've been wanting for a while.

Was wondering if I could make a couple of suggestions on the Proxmox integration:

  1. Display difference between "running" and "not reachable" VMs image I feel like the red tex for running VMs should be a more "positive" colour such as the green online colour/icon used for the services.

  2. "Not reachable" could ideally be "stopped". This generally matches the language used by the Proxmox website.

  3. Templates appear in the VM list, as a standard VM (the VM 9000/7000 in the above screenshot). I'm wondering if it might be best to filter these out.

  4. Connections to the Proxmox VMs. I'm wondering if for the SSH there might be a method of using a key based auth here also, currently it just has the user password option. 652-782-max

  5. Set OS type or connection type. For example I host a variety of OS types on Proxmox including Linux/Windows/macOS. It would be great to be able to select the connection type, RDP/SSH/etc. It might be possible to proxy the console session too, e.g. spice desktop?

crschnick commented 1 month ago
  1. The red text is only to indicate that a connection has not been configured yet and cannot be used right now. As soon as you fill in the missing information, it's listed as normal.
  2. That can be possibly implemented. Right now this is just a catch all because xpipe doesn't do a state detection before connecting. If for whatever reason a connection fails, it will just list it as not reachable
  3. Is there a way to detect that when running qm list when it is a template?
  4. That can be added, I was just under the assumption that most people don't set up their individual vms other than the default authentication. Right now you can still connect to it if you manually add a ssh connection as a workaround
  5. The OS type should ideally be already automatically detected. For other connection types, you can use an individual proxmox connection in xpipe to add other child connections such as RDP if you want. I have not looked into SPICE yet, I can try to find out what is going on there
crschnick commented 1 month ago

I reworked the state display for 2.

You can try it out at https://github.com/xpipe-io/xpipe-ptb and see whether it is now better for you

valdearg commented 1 month ago

Thanks! That does look better on 2!

Sadly it looks like qm list doesn't show if an item is a template, so may not be possible.

I was just taking a look into how Proxmox do it and it looks like the API does display this info, e.g.

        {
            "uptime": 0,
            "maxmem": 2147483648,
            "template": 1,
            "name": "Ubuntu-Server-23.04",
            "cpu": 0,
            "maxdisk": 3758096384,
            "diskread": 0,
            "disk": 0,
            "diskwrite": 0,
            "netout": 0,
            "netin": 0,
            "serial": 1,
            "cpus": 1,
            "vmid": 8000,
            "status": "stopped",
            "mem": 0
        },

But probably a pain to implement vs just the qm list so not to worry about.

crschnick commented 1 month ago

Or is there a specific naming pattern for templates like in your case? Or can the names be completely random, I haven't really used templates

crschnick commented 17 hours ago

The status output has been improved a bit and there's now a toggle to only show running VMs/containers. I think this will get rid of the template issues a bit, at least they are not shown always now