Closed sonam-serchan closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
xplorers-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 0:03am |
Looks like Vercel preview is private and cannot be viewed by everyone
@sonam-serchan LGTM !!! Btw Why the icons and illustrations are different ? Shouldn't it be in a single image modules?. There's something we can look into is DI - seperate module, main tab
Separate modules:
Looks like Vercel preview is private and cannot be viewed by everyone
Should these match? https://docs.google.com/document/d/1RzZXkv0NEtWvAgDTqfG3iLHyOR_WNQzBJXlobbuivTE/edit?usp=sharing
@sonam-serchan LGTM !!! Btw Why the icons and illustrations are different ? Shouldn't it be in a single image modules?. There's something we can look into is DI - seperate module, main tab
- Src -- Home -- About us ----Sub contents of About us -- Contact us ---- Sub contents of contact us
Separate modules:
- DI
- Images
- Localisation ( Strings) -.......
Thanks @Gurungboi, I have created a seperate folder - modules
which will contain each page as a feature!
Looks like Vercel preview is private and cannot be viewed by everyone
Should these match? https://docs.google.com/document/d/1RzZXkv0NEtWvAgDTqfG3iLHyOR_WNQzBJXlobbuivTE/edit?usp=sharing
Oh I see, this might have been updated later once designed in figma. I will address these in a seperate localisation ticket as I need to move around the texts anyway!
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@sonam-serchan LGTM !
Closes #21