search

xpmn / firefox-to-deepl

Firefox extension. Highlight text on a web page and send it to DeepL
https://addons.mozilla.org/en-US/firefox/addon/to-deepl/
MIT License
88 stars 8 forks source link

[Feature Request] Configurable Hot-key #1

Closed SilmorSenedlen closed 3 years ago

SilmorSenedlen commented 4 years ago

Good day, It would be very nice to add ability to use configurable Hot-key to trigger text translation. Is it possible in current architecture of you plugin?

xpmn commented 4 years ago

Yes it is possible, but this will increase the number of permissions required by the extension. This request is the good candidate for the next improvement

SilmorSenedlen commented 4 years ago

Thx for replay. I'll look forward for it!

citydelver commented 3 years ago

Speaking of permissions, this would be a great improvement, but I love the fact that your extension currently does not require any permissions. Could you work with optional permissions?

xpmn commented 3 years ago

Speaking of permissions, this would be a great improvement, but I love the fact that your extension currently does not require any permissions. Could you work with optional permissions?

This is the reason why I didn't implemented this feature yet - it not possible to implement without adding background script which will be running on every page (and for this behaviour the extension will need to have permission to access all data on all pages, which is red flag for many people). I didn't think about optional permissions, I'll check it