search

xpodev / local-history

Visual Studio Code extension for maintaining files versions
https://marketplace.visualstudio.com/items?itemName=xpo.local-history
12 stars 2 forks source link

Jupyter Notebooks are not saved #11

Open klezm opened 2 years ago

klezm commented 2 years ago

I could not use this extension with any Jupyter notebook. For other files it worked though.

neriyaco commented 2 years ago

Hi, can you send a reproduce this issue?

klezm commented 2 years ago

I installed the Extension, changed something inside a jupyter notebook saved it and could not see any history. With e.g. a python file it worked. I tried it again after restarting VSCode, but the issue persisted.

neriyaco commented 1 year ago

Sorry for the very late response, as mentioned here there is no onWillSaveNotebookDocument event. I will try to find a solution for that. It might take some time though as I have to do research about notebooks in general.

klezm commented 1 year ago

VSCode has a built-in file history by now which I am happy with: https://code.visualstudio.com/updates/v1_66#_local-history

neriyaco commented 1 year ago

Yes I know, that's why I left this extension. I will keep this issue open as I got back working on it.