search

xpple / SeedMapper

In-game Minecraft Fabric mod that allows you to do various things with the world seed.
GNU Lesser General Public License v3.0
182 stars 20 forks source link

Showing blocks that do not match that are exposed #20

Open mrphi06 opened 3 years ago

mrphi06 commented 3 years ago

The game crashes when using this on a server with ore obfuscators. This is probably due to the client thinking that every block is not supposed to be there. A potential fix would be to have a setting to only show blocks exposed, such as in the following example:

[X] [-] [-] - - - ( :

The X block, even though it does not match, is not exposed, so it does not show.

[-] [-] {X} - - - ( :

The X block is exposed, so it will be highlighted.

This is my first feature request. Did I do it right?

xpple commented 3 years ago

You said the game crashed, could you provide the crash log?

xpple commented 3 years ago

Also, for what situations would this apply?

mrphi06 commented 3 years ago

Not now, because I have a mod that prevents the entire game from crashing, as my game does crash a lot and start up slowly. I may be able to find it later. It would work for situations where you are looking for blocks that don't fit (maybe base hunting) but the server has the ore obfuscater to prevent people xraying for ores.

xpple commented 3 years ago

Could you try purposely crashing it? The log is quite important to tell what exactly went wrong.

It is hard to detect if the server is obfuscating ores, as each obfuscation might be different from the other. For example, some servers may pretend like there's diamonds everywhere, while others may show coal.

mrphi06 commented 3 years ago

I cannot crash it at the moment, but later I will see if I can (I cannot access Minecraft at this moment) Maybe just checking if the block has air next to it would work? so it only shows if there is air next to it. This would solve any problems from servers obfuscating some ores but not others, or making it seem like there is only coal.

mrphi06 commented 3 years ago

I finally got to my computer! Here is the crash report: https://gist.githubusercontent.com/natanfudge/3280b18f1f156cee88799adb4385393e/raw/a901f05821ece692a99a17bbc503e7ebaa019c0f/crash.txt

networkException commented 3 years ago

This is a duplicate of #21

mrphi06 commented 3 years ago

Thank you. 😃 Is it still possible to add the only showing exposed ores? That way, it works on the anarchy server I play on.

xpple commented 3 years ago

Could you message me on Discord or join my Discord? I (or someone else) will try to reproduce the issue. I’m still a small bit confused about the actual problem you’re having.