xpring-eng / Xpring-SDK-Demo

Demo Code for the Xpring SDK
https://xpring.io
11 stars 14 forks source link

Chunk payid demos #51

Open rmurphy23 opened 4 years ago

rmurphy23 commented 4 years ago

High Level Overview of Change

Context of Change

This change was a simple refactor. It was necessary because if a user going through this demo did not not have a PayID associated with both the XRPL and BTC networks the demo would result in a fatal error. This refactor allows users to demo the PayID resolve according to the networks for which their PayID is associated.

Type of Change

Before / After

Before the refactor there was one file for each of the PayID demos according to their respective language NodeJS, Java, and Swift. After there is three files for each PayID demo according to their respective languages.

Test Plan

Using VS Code I was able to test the NodeJS refactored demos and Java (Maven) refactored demos which both resulted in expected output. I've been unable to test the refactored Swift demos thus they will need more attention.