xpring-eng / Xpring-SDK-Demo

Demo Code for the Xpring SDK
https://xpring.io
11 stars 14 forks source link

[DO NOT MERGE] Encodings Mystery #57

Closed amiecorso closed 4 years ago

amiecorso commented 4 years ago

High Level Overview of Change

Relevant file is node/src/index-xrp.js which can be run with node index-xrp.js.

Issue here: https://github.com/xpring-eng/Xpring-JS/issues/786

Context of Change

Type of Change

Before / After

Test Plan

Stormtv commented 4 years ago

BIP32 doesn't work for us due to the code being built around the Bitcoin network we use fromSeed as seen here https://github.com/bitcoinjs/bip32/blob/master/src/bip32.js#L285

I'd recommend for now deleting the derivation path support.

I'd change this line to const entropy = bip39.mnemonicToEntropy(mnemonic) then the next line to return Wallet.generateWalletFromSeed(addressCodec.encodeSeed(Buffer.from(entropy, 'hex'), 'secp256k1'), test) https://github.com/xpring-eng/xpring-common-js/blob/55790b102fea5ecc302e0119629bc23be64eb5f8/src/XRP/wallet.ts#L112