xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

Refactors PayIDClient to generic networks and subclasses XRPPayIDClient #202

Closed amiecorso closed 4 years ago

amiecorso commented 4 years ago

High Level Overview of Change

This PR makes the following updates:

PayIDClient:

PayIDClientProtocol --> XRPPayIDClientProtocol

XRPPayIDClient

XpringClient

Tests and Fakes:

Context of Change

Type of Change

Before / After

Superclass PayIDClient offers generic network support. Subclass XRPPayIDClient provides better guard rails for XRPL-specific PayID queries.

Test Plan

New integration and unit tests added. CircleCI passes.

codecov-io commented 4 years ago

Codecov Report

Merging #202 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   44.08%   44.08%           
=======================================
  Files          62       62           
  Lines        1969     1969           
=======================================
  Hits          868      868           
  Misses       1101     1101           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2782fc1...2782fc1. Read the comment docs.

keefertaylor commented 4 years ago

The protocol buffer changes in this PR look kinda large + autogenerated. Did you upgrade your proto compiler? Can we do another PR that checks all those in so that this diff is easier to review?

amiecorso commented 4 years ago

The protocol buffer changes in this PR look kinda large + autogenerated. Did you upgrade your proto compiler? Can we do another PR that checks all those in so that this diff is easier to review?

So I don't think I updated my proto compiler... though I did recently do a full wipe of this repo, re-cloned, and followed the build instructions in CONTRIBUTING... any other ideas about what might lead to all these auto-generated diffs? I'll split out the PR.

RESOLVED: ran brew reinstall protobuf swift-protobuf grpc-swift and then re-ran project generation scripts, and autogen diffs were reverted.

amiecorso commented 4 years ago

I am not sure why index.js got regenerated. Was that on purpose?

That was not on purpose... what causes index.js to get regenerated?

keefertaylor commented 4 years ago