Closed amiecorso closed 4 years ago
Merging #202 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 44.08% 44.08%
=======================================
Files 62 62
Lines 1969 1969
=======================================
Hits 868 868
Misses 1101 1101
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2782fc1...2782fc1. Read the comment docs.
The protocol buffer changes in this PR look kinda large + autogenerated. Did you upgrade your proto compiler? Can we do another PR that checks all those in so that this diff is easier to review?
The protocol buffer changes in this PR look kinda large + autogenerated. Did you upgrade your proto compiler? Can we do another PR that checks all those in so that this diff is easier to review?
So I don't think I updated my proto compiler... though I did recently do a full wipe of this repo, re-cloned, and followed the build instructions in CONTRIBUTING... any other ideas about what might lead to all these auto-generated diffs? I'll split out the PR.
RESOLVED: ran brew reinstall protobuf swift-protobuf grpc-swift
and then re-ran project generation scripts, and autogen diffs were reverted.
I am not sure why
index.js
got regenerated. Was that on purpose?
That was not on purpose... what causes index.js
to get regenerated?
High Level Overview of Change
This PR makes the following updates:
PayIDClient
:CryptoAddressDetails
fromaddress
method, instead of just address string. This is to allow access to both address and tag, instead of just returning a classic address and losing tag information.PayIDClientProtocol
-->XRPPayIDClientProtocol
network
becomesxrplNetwork
xrpAddress
method (specific name)XRPPayIDClient
PayIDClient
and conforms toXRPPayIDClientProtocol
xrpAddress
always returns an address in X-Address format.XpringClient
XRPPayIDClientProtocol
instead of aPayIDClient
Tests and Fakes:
FakePayIDClient
-->FakeXRPPayIDClient
toXAddress
conversion used byXRPPayIDClient
Context of Change
Type of Change
Before / After
Superclass
PayIDClient
offers generic network support. SubclassXRPPayIDClient
provides better guard rails for XRPL-specific PayID queries.Test Plan
New integration and unit tests added. CircleCI passes.