xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

Remove Xpring-Common-Protocol-Buffers Submodule #213

Closed keefertaylor closed 4 years ago

keefertaylor commented 4 years ago

High Level Overview of Change

Remove this submodule. It is dead code.

Context of Change

We removed code depending on this submodule. No reason to keep the submodule reference around.

Type of Change

Before / After

N/A

Test Plan

CI

codecov[bot] commented 4 years ago

Codecov Report

Merging #213 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   44.71%   44.71%           
=======================================
  Files          62       62           
  Lines        1997     1997           
=======================================
  Hits          893      893           
  Misses       1104     1104           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ec5bc4...ecd01a5. Read the comment docs.

keefertaylor commented 4 years ago

Ping @tedkalaw