search

xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

Fix Destination Tags #245

Closed keefertaylor closed 4 years ago

keefertaylor commented 4 years ago

High Level Overview of Change

Fix an issue where XpringKit drops destination tags on sends.

Addresses issue https://github.com/xpring-eng/xpring4j/issues/264.

Context of Change

Our serialization library expects destination addresses to be in X-Address format and xpring4j was providing classic address / tag combinations.

The serialization library shouldn't mess this up. That change is in https://github.com/xpring-eng/xpring-common-js/pull/346.

This change fixes the immediate issue by passing through X-Addresses. Add an integration test to prove this works as expected.

We will do a release ASAP after this change is merged.

Type of Change

Before / After

Fixes a bug.

Test Plan

CI. New tests are provided.

codecov[bot] commented 4 years ago

Codecov Report

Merging #245 into master will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   88.25%   88.44%   +0.18%     
==========================================
  Files          42       42              
  Lines         877      874       -3     
==========================================
- Hits          774      773       -1     
+ Misses        103      101       -2
Impacted Files Coverage Δ
XpringKit/XRP/DefaultXRPClient.swift 98.60% <100.00%> (+1.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59478d5...e0e2fbf. Read the comment docs.