xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

Add Tests for `XRPPayIDClient` #252

Closed keefertaylor closed 4 years ago

keefertaylor commented 4 years ago

High Level Overview of Change

Add additional tests for XRPPayIDClient

Context of Change

This change brings us to testing parity with the other SDK tests (ex: Xpring-JS tests).

Type of Change

Before / After

PayIDClient is now sufficiently tested.

Test Plan

CI

codecov[bot] commented 4 years ago

Codecov Report

Merging #252 into master will increase coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   89.69%   90.01%   +0.31%     
==========================================
  Files          42       42              
  Lines         941      941              
==========================================
+ Hits          844      847       +3     
+ Misses         97       94       -3     
Impacted Files Coverage Δ
XpringKit/PayID/XRPPayIDClient.swift 85.00% <100.00%> (ø)
XpringKit/PayID/PayIDClient.swift 100.00% <0.00%> (+3.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfbf6aa...72beb7e. Read the comment docs.