xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

Minor updates to PayID Documentation #253

Closed keefertaylor closed 4 years ago

keefertaylor commented 4 years ago

High Level Overview of Change

Resolve a TODO and link to a formal specification for network headers.

Context of Change

Post launch cleanup.

Type of Change

Before / After

n/a

Test Plan

CI

codecov[bot] commented 4 years ago

Codecov Report

Merging #253 into master will increase coverage by 1.65%. The diff coverage is 95.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   88.03%   89.69%   +1.65%     
==========================================
  Files          42       42              
  Lines         861      941      +80     
==========================================
+ Hits          758      844      +86     
+ Misses        103       97       -6     
Impacted Files Coverage Δ
...ingKit/PayID/JavaScript/JavaScriptPayIDUtils.swift 100.00% <ø> (ø)
XpringKit/PayID/XRPPayIDClient.swift 85.00% <82.60%> (+3.18%) :arrow_up:
XpringKit/PayID/PayIDClient.swift 96.55% <95.65%> (+15.30%) :arrow_up:
XpringKit/XRP/DefaultXRPClient.swift 98.60% <100.00%> (+1.43%) :arrow_up:
...XRP/Model/XRPPayment+Org_Xrpl_Rpc_V1_Payment.swift 100.00% <100.00%> (ø)
...l/XRPTransaction+Org_Xrpl_Rpc_V1_Transaction.swift 96.00% <100.00%> (+0.44%) :arrow_up:
XpringKit/XRP/ReliableSubmissionXRPClient.swift 94.23% <100.00%> (+0.11%) :arrow_up:
XpringKit/XRP/XRPClient.swift 100.00% <100.00%> (ø)
XpringKit/Xpring/XpringClient.swift 100.00% <100.00%> (+5.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f60a77...8819fbc. Read the comment docs.