Closed amiecorso closed 4 years ago
Merging #275 into master will increase coverage by
0.28%
. The diff coverage is96.36%
.
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 90.40% 90.68% +0.28%
==========================================
Files 48 51 +3
Lines 1105 1160 +55
==========================================
+ Hits 999 1052 +53
- Misses 106 108 +2
Impacted Files | Coverage Δ | |
---|---|---|
...Model/XRPCheckCash+Org_Xrpl_Rpc_V1_CheckCash.swift | 93.33% <93.33%> (ø) |
|
...l/XRPCheckCreate+Org_Xrpl_Rpc_V1_CheckCreate.swift | 95.83% <95.83%> (ø) |
|
...epositPreauth+Org_Xrpl_Rpc_V1_DepositPreauth.swift | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2066bab...ee0932b. Read the comment docs.
High Level Overview of Change
This PR implements the class
XRPDepositPreauth
- a native Swift struct to wrap theDepositPreauth
protocol buffer. See also https://xrpl.org/depositpreauth.htmlContext of Change
Effort to implement additional XRPL transaction types beyond
Payment
in the SDK.Type of Change
Before / After
XRPDepositPreauth
class and conversion unit tests now exist.Test Plan
Unit tests added to verify conversion. CI passes.
Future Tasks