Closed amiecorso closed 4 years ago
Merging #279 into master will increase coverage by
0.45%
. The diff coverage is95.45%
.
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 90.40% 90.86% +0.45%
==========================================
Files 48 55 +7
Lines 1105 1215 +110
==========================================
+ Hits 999 1104 +105
- Misses 106 111 +5
Impacted Files | Coverage Δ | |
---|---|---|
...XRPEscrowCancel+Org_Xrpl_Rpc_V1_EscrowCancel.swift | 90.00% <90.00%> (ø) |
|
...Model/XRPCheckCash+Org_Xrpl_Rpc_V1_CheckCash.swift | 93.33% <93.33%> (ø) |
|
...XRPEscrowFinish+Org_Xrpl_Rpc_V1_EscrowFinish.swift | 94.44% <94.44%> (ø) |
|
...XRPEscrowCreate+Org_Xrpl_Rpc_V1_EscrowCreate.swift | 95.45% <95.45%> (ø) |
|
...l/XRPCheckCreate+Org_Xrpl_Rpc_V1_CheckCreate.swift | 95.83% <95.83%> (ø) |
|
...epositPreauth+Org_Xrpl_Rpc_V1_DepositPreauth.swift | 100.00% <100.00%> (ø) |
|
...l/XRPOfferCancel+Org_Xrpl_Rpc_V1_OfferCancel.swift | 100.00% <100.00%> (ø) |
|
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 72fa3f9...cb414ae. Read the comment docs.
High Level Overview of Change
This PR implements the class
XRPOfferCancel
- a native Swift struct to wrap theOfferCancel
protocol buffer. See also https://xrpl.org/offercancel.htmlContext of Change
Effort to implement additional XRPL transaction types beyond
Payment
in the SDK.Type of Change
Before / After
XRPOfferCancel
class and conversion unit tests now exist.Test Plan
Unit tests added to verify conversion. CI passes.
Future Tasks