xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

(13/17) Creates `XRPPaymentChannelCreate` Protobuf Wrapper Class #282

Closed amiecorso closed 4 years ago

amiecorso commented 4 years ago

High Level Overview of Change

This PR implements the class XRPPaymentChannelCreate - a native Swift struct to wrap the PaymentChannelCreate protocol buffer. See also https://xrpl.org/paymentchannelcreate.html

Context of Change

Effort to implement additional XRPL transaction types beyond Payment in the SDK.

Type of Change

Before / After

XRPPaymentChannelCreate class and conversion unit tests now exist.

Test Plan

Unit tests added to verify conversion. CI passes.

Future Tasks

codecov[bot] commented 4 years ago

Codecov Report

Merging #282 into master will decrease coverage by 0.06%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   90.77%   90.71%   -0.07%     
==========================================
  Files          57       58       +1     
  Lines        1258     1282      +24     
==========================================
+ Hits         1142     1163      +21     
- Misses        116      119       +3     
Impacted Files Coverage Δ
...lCreate+Org_Xrpl_Rpc_V1_PaymentChannelCreate.swift 87.50% <87.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 475e914...1448f25. Read the comment docs.