xpring-eng / XpringKit

XpringKit provides a Swift SDK for interacting with Xpring Protocols (XRP/PayID/ILP). This library is deprecated.
https://xrpl.org/
MIT License
26 stars 14 forks source link

(16/17) Creates `XRPSignerListSet` and `XRPSignerEntry` Protobuf Wrapper Classes #285

Closed amiecorso closed 4 years ago

amiecorso commented 4 years ago

High Level Overview of Change

This PR implements the class XRPSignerListSet and a dependency XRPSignerEntry - native Swift structs to wrap the XRPSignerListSet protocol buffer (See also https://xrpl.org/signerlistset.html), and the XRPSignerEntry protocol buffer (see also https://xrpl.org/signerlist.html#signerentry-object)

Context of Change

Effort to implement additional XRPL transaction types beyond Payment in the SDK.

Type of Change

Before / After

XRPSignerListSet class and conversion unit tests now exist. XRPSignerEntry class and conversion unit tests now exist.

Test Plan

Unit tests added to verify conversion. CI passes.

Future Tasks

codecov[bot] commented 4 years ago

Codecov Report

Merging #285 into master will increase coverage by 0.51%. The diff coverage is 93.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   90.28%   90.79%   +0.51%     
==========================================
  Files          46       62      +16     
  Lines        1091     1315     +224     
==========================================
+ Hits          985     1194     +209     
- Misses        106      121      +15     
Impacted Files Coverage Δ
...XRP/Model/XRPPayment+Org_Xrpl_Rpc_V1_Payment.swift 100.00% <ø> (ø)
...nelClaim+Org_Xrpl_Rpc_V1_PaymentChannelClaim.swift 86.66% <86.66%> (ø)
...annelFund+Org_Xrpl_Rpc_V1_PaymentChannelFund.swift 86.66% <86.66%> (ø)
...lCreate+Org_Xrpl_Rpc_V1_PaymentChannelCreate.swift 87.50% <87.50%> (ø)
...XRPEscrowCancel+Org_Xrpl_Rpc_V1_EscrowCancel.swift 90.00% <90.00%> (ø)
...l/XRPOfferCreate+Org_Xrpl_Rpc_V1_OfferCreate.swift 92.30% <92.30%> (ø)
...Model/XRPCheckCash+Org_Xrpl_Rpc_V1_CheckCash.swift 93.33% <93.33%> (ø)
...XRPEscrowFinish+Org_Xrpl_Rpc_V1_EscrowFinish.swift 94.44% <94.44%> (ø)
...XRPEscrowCreate+Org_Xrpl_Rpc_V1_EscrowCreate.swift 95.45% <95.45%> (ø)
...l/XRPCheckCreate+Org_Xrpl_Rpc_V1_CheckCreate.swift 95.83% <95.83%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f225292...00a014c. Read the comment docs.