xproc / 3.0-steps

Repository for change requests to the standard step library and for official extension steps
10 stars 7 forks source link

Clarify that for merge=false, “unsupplied” properties will be removed #282

Closed gimsieke closed 4 years ago

gimsieke commented 4 years ago

fix #281

xml-project commented 4 years ago

I think we should explictly say that the resulting document does not have a base URI in this case, because I expect this to be a cause for confusion.

gimsieke commented 4 years ago

With “effectively” I wanted to shield myself from pedantic remarks claiming that the properties won’t be removed because a new document is created and it will be created without the properties in question. But apparently the attempt wasn’t as “effective” as I had hoped. So if everyone is comfortable with the IMO slightly sloppy “will be removed from the document”, I’m fine with it, too.

ndw commented 4 years ago

"Slightly sloppy". Zing! Them's fighting words. I now propose:

If is true, document properties not overridden by settings in the map are preserved, otherwise the resulting document has only the content-type property and the properties specified in the map. In particular, if is false, the base-uri property will not be preserved.
gimsieke commented 4 years ago

…if merge is false and if base-uri is omitted in the properties map, the base-uri property will not be preserved.

gimsieke commented 4 years ago

No, it’s ok. It doesn’t need to be omitted in order not to be preserved. I will use your words.

xml-project commented 4 years ago

I am not sure that fits with the specs. We say:

The value of the “base-uri” property identifies the base URI of the document;

so we should say, that the resulting document will not have a base URI.

gimsieke commented 4 years ago

Acceptable now?

xml-project commented 4 years ago

Thanks Gerrit!