First draft of p:http-request

xproc / 3.0-steps

Repository for change requests to the standard step library and for official extension steps

10 stars 7 forks source link

First draft of p:http-request #330

Closed xml-project closed 4 years ago

xml-project commented 4 years ago

Please find here the first draft on p:http-request which is to replace the existing text comming from the 1.0 specs. @ndw @xatapult @Gertone @gimsieke "Edit from maintainers" is on, so feel free to make changes.

xatapult commented 4 years ago

Is there a build where we can look at the formatted result somewhere?

And there are no reviewers mentioned. Intentional or oversight?

xml-project commented 4 years ago

Is there a build where we can look at the formatted result somewhere?

Send you a mail this afternoon.

And there are no reviewers mentioned. Intentional or oversight?

As it is not finished, I did not want to ask for a review because I am not sure, we want to merge it in this state. Any opinion?

xatapult commented 4 years ago

Probably the devil is in the details, but this looks very OK to me. It reflects (as far as I remember) what we spoke about in Cologne and later.

ndw commented 4 years ago

I thought there were some changes proposed at our editor's call. I think it makes sense to make those changes and make another editorial pass.

xml-project commented 4 years ago

@ndw I thought I did make the requested changes from editors call. What did I left out?

xatapult commented 4 years ago

I took the liberty to change some words and grammar without changing meaning.

xatapult commented 4 years ago

The description of the serialization option differs.

The introduction mentions that the serialization property is ignored when more than one document appears on the source port
Later on it says that the serialization property is used for all documents on the source port

xatapult commented 4 years ago

Urgh. What did I do to make the build fail? Can't make sense of the Travis generated error message

xml-project commented 4 years ago

@xatapult Oh, left that out.

ndw commented 4 years ago

At a glance, @xatapult you've made steps/http-request.xml not well-formed XML or not valid DocBook.

xml-project commented 4 years ago

Not sure what happend, but now I am out on my own PR. Trying to push something to my repo's branch git says, I had to merge Erik changes first. No idea what that means. Let's see if it goes away once travis passes.

xml-project commented 4 years ago

@xatapult

Urgh. What did I do to make the build fail? Can't make sense of the Travis generated error message

It is in line 131: a \ close is missing. Sorry, can't fix it for you.

xatapult commented 4 years ago

Maybe we should limit the discussion(s) about http-request to a single issue. You now mention several. So I suggest to close all except one (or all and open a new one especially for finishing http-request)