search

xproc / 3.0-steps

Repository for change requests to the standard step library and for official extension steps
10 stars 7 forks source link

version attribute on p:declare-step / p:library in p:run #449

Closed xml-project closed 2 years ago

xml-project commented 4 years ago

Contrary to the example given for p:run, I think that a version atrribute on p:declare-step / p:library is required for a pipeline to be executed by p:run. The specs say:

If the p:declare-step has no ancestors in the XProc namespace, then it must have a version attribute.

In the example the pipeline has an ancestor in XProc's namespace, but once the document arrives on the input port of p:run it is impossible for the step to know whether this was the case.

ndw commented 4 years ago

I agree.

xatapult commented 4 years ago

Me too

gimsieke commented 4 years ago

In https://github.com/xproc/3.0-steps/issues/447#issuecomment-674533271, I added the version attribute to the dynamically executed pipeline.

xatapult commented 4 years ago

The step p:run runs must have a version attribute

gimsieke commented 3 years ago

Was already addressed with f24f398 / PR #461

gimsieke commented 3 years ago

Changed 3.1 to 3.0 in the example (PR #472, commit 34043bc)

xatapult commented 2 years ago

@gimsieke Can this one be closed? It seems to be addressed.

ndw commented 2 years ago

I think this is resolved.