search

xproc / 3.0-test-suite

The 3.0 test suite.
https://test-suite.xproc.org/
MIT License
4 stars 3 forks source link

Fixed error code in ab-validate-with-json-schema-009 #750

Closed ndw closed 3 weeks ago

ndw commented 3 weeks ago

Test ab-validate-with-json-schema-009 claims that err:XC0163 should be raised, but the test is for "input is not a JSON schema" which, by my reading, is err:XC0164. I think err:XC0163 is for JSON schemas that have an unsupported version.

Or do I missunderstand?

xml-project commented 3 weeks ago

Not sure we have the same understanding of $schema. The prose in this test is surely missleading, but to my understanding $schema tells the validator which dialect/version should be used. And as the validator can not use the version/dialect indicated in the test, XC0163 seem to be right for me. Does this make sense?

ndw commented 3 weeks ago

I think part of my confusion stemmed from the fact that the $schema points to a resource that doesn't exist. So the validator I'm using throws an resource-not-found exception and I was trying to interpret that as an error. "Not a schema" seems like a better match than "not the right version", but I see why that's wrong.