search

xps / VSTextMacros

An extension for Visual Studio 2012-2022 that brings back support for macros in text/code editors
https://marketplace.visualstudio.com/items?itemName=XavierPoinas.TextMacrosforVisualStudio201220132015
Other
69 stars 20 forks source link

Start/stop recording macro is not grayed out when focusing search field #28

Open hsandt opened 5 years ago

hsandt commented 5 years ago

When focusing the Find/Replace top-right embedded panel, the Start/Stop recording menu item is present but clicking on it / using its shortcut does nothing.

This is problematic as I'm trying to record a "Search current selection" macro with Ctrl+C, Ctrl+F, Ctrl+V which ends in the search panel. I need to click back on the document to stop the macro recording.

Actually, the macro recorder doesn't seem to be able to record the Find action anyway (unlike the official VS Macros plugin, but that I'm not using because the macro shortcut mapping wasn't working). But then it should gray out the _Start/Stop recording menu item in a Find context.

Note 1: In the Find and Replace (in files) pop-up, the menu item doesn't appear at all, so there is no doubt we cannot use it there. Note 2: I know I can check "Automatically populate Find What with text from the editor" in Options > Environment > Find and Replace, but I specifically unchecked it not to fill the search field with the current word under caret. I am just creating a macro for cases where I really want to search the current selection sometimes (basically when selection is not empty).

xps commented 5 years ago

Unfortunately, recording find operations is simply not supported. More details here: https://github.com/xps/VSTextMacros/issues/1

I didn't realize that the official Macro extension could do that. It is open source so when I get some time I will check their implementation and see if this is something that can be added to our extension.

hsandt commented 5 years ago

OK, so let's consider the actual issue for now is only about UI feedback: "Start/stop recording macro is not grayed out when focusing search field"? Should I edit the title since otherwise it would become a duplicate of #1 ?

xps commented 5 years ago

Sure, let's rename it to that. Thanks for reporting this.