Check tutorials/notebook for mentions of `antiphase=True` or `-0.5` phase added in Priors

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference

Other

34 stars 20 forks source link

Check tutorials/notebook for mentions of `antiphase=True` or `-0.5` phase added in Priors #296

Closed sguillot closed 1 week ago

thjsal commented 1 year ago

Usage of them looks consistent in the Tutorials for me. I.e., always when using antiphase=True (or is_secondary=True), we have -0.5 added in the phase in the CustomPrior.py.

Are you suggesting to change it everywhere so that antiphase=False and remove the 0.5 from priors?

sguillot commented 1 year ago

Yes. This was discussed during the hackweek to discard the (confused) -0.5 prior.

thjsal commented 1 year ago

Okay, sounds a good idea! It will then also solve this issue #291.

thjsal commented 1 week ago

I think it is fine to close this issue, since it is essentially a duplicate (or overlaps very strongly) with the issue #323 .