Closed sguillot closed 1 year ago
I think we discussed this with @DevarshiChoudhury at some point and found that the column density variable (with a slightly different name now) is just defined differently in the modules generated by the module generator (and therefore the difference). But it should work correctly.
I am not very convinced by your response :-)
I haven't noticed any other differences in the CustomInterstellar scripts. And presumably, users will use the interstellar_phot_frac.txt
files that are in the Zenodo (I don't think it's distributed with XPSI), which then will give different results no?
That correction isn't required since the scaling will simply account for that difference in definition, just that now the N_H value inferred will be in terms of the fiducial column density, so instead of e20 cm^-2, the units will be 0.4e20 cm^-2. This fact is documented in the docstrings generated for N_H linked above. There is no difference as such in the scripts
I see. Thanks for the clarification. This is going to confuse the hell out of people I think. But I guess, we can close the issue
The reason behind this choice was that the module generator can be used for files different from interstellar_phot_frac.txt
currently being used by us, where the fiducial column density is different.
I noticed that the attenuation in the
CustomInterstellar.py
script located with the module generator is calculated with:But all the
CustomInterstellar.py
used elsewhere for the runs have:with the factor of 0.4.