xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Installation instruction updates #335

Closed thjsal closed 9 months ago

thjsal commented 11 months ago

Things to be fixed/updated in the installation instructions:

evertrol commented 11 months ago

You may also want to add another little part to the clean-up command at the bottom of the XPSI installation section (just above the "Documentation" section), to remove the generated rayXpanda object files:

rm -r build dist *egg* xpsi/*/*.c xpsi/include/rayXpanda/*.o

(it may complain the files are not found if the included rayXpanda package was not used.)

Note that this concerns the object files, not the C source files, since the C files are the actual source files here (i.e., there are no Cython .pyx files). And since these are compiled in-place (see the sub.call() lines in setup.py), the object files are left in the source directory. Which could cause problems during a new build.

thjsal commented 10 months ago

We should also add sudo apt install mpich to instruction, to make sure mpif90 is installed.