search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Installation instructions updated #352

Closed thjsal closed 9 months ago

thjsal commented 9 months ago

Installation instructions are updated based on the latest feedback and issues #335 #336 .

thjsal commented 9 months ago

xpsi/include/rayXpanda/*.o does not work for me because I never installed rayXpanda (I get: rm: cannot remove 'xpsi/include/rayXpanda/*.o': No such file or directory). Not sure why this is needed?

I followed what @evertrol suggested here: https://github.com/xpsi-group/xpsi/issues/335#issuecomment-1761542722

I am not sure if that is actually needed, since we don't usually use rayXpanda. Interesting though that you don't have any *.o files there, since I seem to have them there even in systems where I have not installed rayXpanda.

evertrol commented 9 months ago

Yes, it's a bit confusing if there are no actual files to remove. Perhaps it's an idea to add the -f option to rm (together with -r where needed), so that rm will just ignore non-existent files and directory and not complain about it and fail.

evertrol commented 9 months ago

I am not sure if that is actually needed, since we don't usually use rayXpanda. Interesting though that you don't have any *.o files there, since I seem to have them there even in systems where I have not installed rayXpanda.

Perhaps I'm overlooking a few things (after all, this is not software I often, if at all, use), but in setup.py, aren't the inversion.o and deflection.o created by default when rayXpanda can't be imported? As some sort of dummy interface? (Even if the .so shared library files may never be created from the object files.)

Though that does not agree with MHoogkamer's assessment that rayXpanda was never installed, but the .o files are also not present. 🤔

thjsal commented 9 months ago

@MHoogkamer just reported that this problem does not occur anymore. So probably something was wrong (e.g. X-PSI being not completely compiled) when trying that first time. Thus, I think removing the rayXpanda *.o files should be ok.