search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Background improvements and fixes #355

Closed thjsal closed 7 months ago

thjsal commented 9 months ago

Includes also fixes/updates to post-processing and module generator.

thjsal commented 7 months ago

@DevarshiChoudhury Actually, I realized that this warning is now printed sometimes when it even should not be needed. The warning should be there only if the "if" or "elif" conditions are not fulfilled at any iteration in the for-loop (so not at each iterations missing those conditions).

Perhaps this warning is actually not needed here at all, since with this pull request we now have anyway a check done also in the background marginalization function itself, that raises an error if there are any background upper limits set to zero (which is the actual problem, instead of the background itself being zero).