search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Option to allow spherical star and other simplifications #359

Open thjsal opened 7 months ago

thjsal commented 7 months ago

For testing and code comparison purposes, it can be handy to have the option to calculate the pulses from a spherical neutron star (instead of an oblate).

Here are instructions on how to make the star spherical currently in X-PSI:

Make this line: https://github.com/xpsi-group/xpsi/blob/7627389df9ed994a086d17d0ffd6eae4eb95a526/xpsi/cellmesh/mesh_tools.pyx#L20 to return 1.0.

Make this line: https://github.com/xpsi-group/xpsi/blob/7627389df9ed994a086d17d0ffd6eae4eb95a526/xpsi/cellmesh/mesh_tools.pyx#L31 to return 0.0.

Make this line: https://github.com/xpsi-group/xpsi/blob/7627389df9ed994a086d17d0ffd6eae4eb95a526/xpsi/surface_radiation_field/effective_gravity_universal.pyx#L32 to return log10(g_0) + 2.0.

And then re-install X-PSI.

We can also think if turning time delays off could be a useful option. That can be turned off currently by setting _phase_lag=0.0 in the integrator files found in https://github.com/xpsi-group/xpsi/tree/main/xpsi/cellmesh and then re-installing X-PSI.