search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

`args.hot_atmosphere_model` implementation generated for `main` by `module_generator` does not work when choosing blackbody atmosphere #369

Closed DevarshiChoudhury closed 4 months ago

DevarshiChoudhury commented 6 months ago

https://github.com/xpsi-group/xpsi/blob/6aeef9a0d35620be3195aabd9844e365bd0be0c4/xpsi/module_generator.py#L1948

https://github.com/xpsi-group/xpsi/blob/6aeef9a0d35620be3195aabd9844e365bd0be0c4/xpsi/module_generator.py#L1993 The above ways of opting for BB vs NSX atmospheres do not work, since args.hot_atmosphere_model is not a config.ini argument but a generate.ini argument.

\ Make changes in the following manner to have main take in either blackbody or NSX atmosphere: https://github.com/xpsi-group/xpsi/blob/6aeef9a0d35620be3195aabd9844e365bd0be0c4/xpsi/module_generator.py#L2756

Also check if elsewhere implementations account for such choice of NSX vs BB atmosphere. Right now they don't have this same bug but might just be capable of invoking BB atmosphere by itself.