xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

PDT-U projection tool bug fixed and units set to roman font. #370

Closed thjsal closed 5 months ago

thjsal commented 6 months ago

Bug in the projection tool for PDT-U model fixed (the components of the secondary region were not shown). In addition, the font type of the units was changed from italic to roman. Here a figure before the update Projection_from_PrimarySuper_old and here the same figure after the update: Projection_from_PrimarySuper_new

I also checked that the code still works correctly for ST-U.

thjsal commented 6 months ago

As seen from the figures, the color choices are also not very optimal for PDT-U. It is hard to separate the circles, since the color looks the same if the primary circle is on the front side and if the secondary circle is on the back side of the star. I think we would need to either change the colors or make curves dashed instead of dimmed when they are behind the star.

DevarshiChoudhury commented 6 months ago

I think colour changes might be better since having more dashed lines would make the plot look too busy. Suggestion: Primary spot html colours: super-#D81B60, cede-#1E88E5 Secondary spot html colours: super-#004D40, cede-#FFC107 These colours were chosen to also be colour-blind friendly (regular appearance is the left-most in the image attached)

image

thjsal commented 6 months ago

Do you have an example figure that you can paste here, of where it doesn't seem to work @thjsal ?

The first figure I posted is the example figure that does not work. You see that it does not plot all the circles it should. The second figure is the same figure after the change in the code.

thjsal commented 6 months ago

Probably then need to look at the colors a bit later (perhaps when Serena is back). How they are set in the code seems a bit complicated to me and changing the colors may also break the current connection between colors and temperatures of the spots.

serenavinciguerra89 commented 5 months ago

Everything looks fine to me :)